Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39677 )
Change subject: drivers/usb/acpi: Add needed #include file ......................................................................
drivers/usb/acpi: Add needed #include file
The chip.h for this driver was updated to add a reset GPIO, but did not add the required #include of <arch/acpi_device.h>. This likely still compiled because other chip.h files included before it may have included it themselves.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I13200f7347fd17739a377e8ad0906ab7e5d6ae1b --- M src/drivers/usb/acpi/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39677/1
diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index bce73c6..79033bb 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -14,6 +14,7 @@ #ifndef __USB_ACPI_CHIP_H__ #define __USB_ACPI_CHIP_H__
+#include <arch/acpi_device.h> #include <arch/acpi.h> #include <arch/acpi_pld.h>
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39677 )
Change subject: drivers/usb/acpi: Add needed #include file ......................................................................
Patch Set 2: Code-Review+2
Hello Bora Guvendik, build bot (Jenkins), Furquan Shaikh, Selma Bensaid, Nick Vaccaro, Kevin Chowski, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39677
to look at the new patch set (#3).
Change subject: drivers/usb/acpi: Add needed #include file ......................................................................
drivers/usb/acpi: Add needed #include file
The chip.h for this driver was updated to add a reset GPIO, but did not add the required #include of <arch/acpi_device.h>. This likely still compiled because other chip.h files included before it may have included it themselves.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I13200f7347fd17739a377e8ad0906ab7e5d6ae1b --- M src/drivers/usb/acpi/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39677/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39677 )
Change subject: drivers/usb/acpi: Add needed #include file ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39677 )
Change subject: drivers/usb/acpi: Add needed #include file ......................................................................
drivers/usb/acpi: Add needed #include file
The chip.h for this driver was updated to add a reset GPIO, but did not add the required #include of <arch/acpi_device.h>. This likely still compiled because other chip.h files included before it may have included it themselves.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I13200f7347fd17739a377e8ad0906ab7e5d6ae1b Reviewed-on: https://review.coreboot.org/c/coreboot/+/39677 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/usb/acpi/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index bce73c6..79033bb 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -14,6 +14,7 @@ #ifndef __USB_ACPI_CHIP_H__ #define __USB_ACPI_CHIP_H__
+#include <arch/acpi_device.h> #include <arch/acpi.h> #include <arch/acpi_pld.h>
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)