Attention is currently required from: Furquan Shaikh, Martin Roth, Bhanu Prakash Maiya, Paul Menzel, Rob Barnes, Eric Peers, Karthik Ramasubramanian.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57976 )
Change subject: mb/google/guybrush/var/nipperkin: config eSPI alert as in-band
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57976/comment/43654789_bcde4f33
PS2, Line 131: register "common_config.espi_config.alert_pin" = "ESPI_ALERT_PIN_IN_BAND"
We observed eSPI bus errors during S0ix resume when using in-band alerts b/197965075. […]
hi Rob,
can't access b/197965075, could you please loop ODM group in? thank you!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18d38fe504bd9f2069b9977d5a35729691f672d1
Gerrit-Change-Number: 57976
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 01:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment