Attention is currently required from: Nico Huber.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81883?usp=email )
Change subject: superio/nuvoton/nct6779d: Add power_on_after_fail support ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
We could also make it a common function for Nuvoton SIOs?
Yes, this as far as I can see can be shared among at least 3 nuvoton SIOs. Will investigate. May even expand this patch as such.
File src/superio/nuvoton/nct6779d/superio.c:
https://review.coreboot.org/c/coreboot/+/81883/comment/38848d20_a46a7620 : PS1, Line 37: */
Same for the `cmos.layout` in case it's used. Not sure if it's worth that […]
Heh, I tend to optimize for runtime code size. However, this is defined at src/mainboard/Kconfig and hopefully no one is going to change it.
Not sure if gcc can pick up on code like:
int b; switch (a) { case 0: b=0; break; case 1: b=1; break; case 2: b=2; break; default: }
(which is essentially what nct5572d does) and optimize it to something more reasonable, such as my code.