[S] Change in coreboot[master]: amdfwtool:combo: Add combo feature for BIOS table - coreboot-gerrit

2 Mar 2023


      Attention is currently required from: Bao Zheng, Zheng Bao, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66856 )
Change subject: amdfwtool:combo: Add combo feature for BIOS table
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/66856/comment/22a10f9c_ca63f86d 
PS8, Line 2605: 		adjust_current_pointer(&ctx, 0, 0x1000U); /* TODO: is it necessary? */
Is this TODO necessary?  Is it just to align on a 4K boundary?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/66856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0523a4a0e1f31969e4bbaa6062dcc0f2d6da420
Gerrit-Change-Number: 66856
Gerrit-PatchSet: 8
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 13:44:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment