Attention is currently required from: Martin Roth, Paul Menzel, Werner Zeh.
Anand Mistry has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55001 )
Change subject: soc/amd/stoneyridge: Set missing RTC offsets for day alarm and century
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/stoneyridge/acpi.c:
https://review.coreboot.org/c/coreboot/+/55001/comment/43bc91c0_925f5e10
PS3, Line 87: fadt->century = 0x32;
Hi Could you please have a look at CB:55012 and tell me what you think?
That looks good to me, but I can only talk about stoneyridge/picasso. I don't normally work on coreboot, so I don't have much of an opinion otherwise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10831b982662e680fa71aa81d02935e1b7e7a7a1
Gerrit-Change-Number: 55001
Gerrit-PatchSet: 3
Gerrit-Owner: Anand Mistry
amistry@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 07:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment