[M] Change in coreboot[master]: soc/amd: Create AMD common reset code

[Martin L Roth (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Elyes Haouas, Felix Held.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72658 )

Change subject: soc/amd: Create AMD common reset code
......................................................................

Patch Set 2:

(4 comments)

File src/soc/amd/common/block/include/amdblocks/reset.h:

https://review.coreboot.org/c/coreboot/+/72658/comment/f72ffdc6_91b2085d 
PS1, Line 10: #include <soc/southbridge.h>
            : 
            : 
            : void do_warm_reset(void);
> Thanks, that was a mistake.

Done

File src/soc/amd/common/block/pm/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/72658/comment/e768e984_43acdb29 
PS2, Line 4: bootblock-$(CONFIG_SOC_AMD_COMMON_BLOCK_RESET) += reset.c
I originally had this as I did in the original patch:

ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_RESET),y)
 bootblock-y	+= reset.c
 verstage_x86-y	+= reset.c
 romstage-y	+= reset.c
 ramstage-y	+= reset.c
 endif

I modified it to match the style, but I figure whichever way I do it someone's going to hate it, so I changed it to match the style already in the file.

If there's actually a document that indicates the correct style here, I'll change it to match that, otherwise I'm leaving it like this.

File src/soc/amd/common/block/reset/reset.c:

PS1:
> There's a lot of stuff that resides in various register blocks just because that's where they put it […]

Moved.

https://review.coreboot.org/c/coreboot/+/72658/comment/f5977ef2_aa15d768 
PS1, Line 22: 	outb(RST_CPU | SYS_RST, RST_CNT);
> How about just adding a comment that do_cold_reset() doesn't return? I can't say I really like eithe […]

Added a comment.