Change in coreboot[master]: mb/google/volteer/variant/lindar: Update devicetree settings for touc...

[Stanley Wu (Code Review)]

Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad

Update I2C address for Goodix touchscreen and add ELAN touchscreen & Synaptics trackpad.

BUG=b:160013582
TEST=emerge-puff coreboot and check system dmesg and evtest can get device.

Change-Id: I070fb0e06b588f128253270502c9c2c427c62b84
Signed-off-by: Stanley Wu 
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 22 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47390/1

diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index 87ca0a3..03cef1c 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -58,7 +58,19 @@
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
-				device i2c 14 on end
+				device i2c 5d on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0001""
+				register "desc" = ""ELAN Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
+				register "enable_delay_ms" = "1"
+				register "has_power_resource" = "1"
+				device i2c 10 on end
    		end
    	end
    	device ref i2c5 on
@@ -70,6 +82,15 @@
    			register "probed" = "1"
    			device i2c 15 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E15_IRQ)"
+				register "generic.wake" = "GPE0_DW2_15"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 2c on end
+			end
    	end
    	device ref north_xhci on
    		chip drivers/usb/acpi

[Stanley Wu (Code Review)]

Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

Set Ready For Review

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG@6 
PS1, Line 6: 
           : mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
           : 
           : Update I2C address for Goodix touchscreen and add ELAN touchscreen & Synaptics trackpad.
           : 
           : BUG=b:160013582
           : TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Please keep all lines to 72 characters.
suggestion:
```
mb/google/volteer: Update lindar's devicetree settings

Add I2C chip drivers for the touchpad and touchscreen to lindar's
devicetree.
```

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
PS1, Line 66: EDGE
LEVEL, see CB:47415

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
PS1, Line 88: EDGE
LEVEL, see CB:47415

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47390

to look at the new patch set (#2).

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

mb/google/volteer/variant/lindar: Update devicetree settings for
touchscreen and trackpad

Update I2C address for Goodix touchscreen and add ELAN touchscreen &
Synaptics trackpad.

BUG=b:160013582
TEST=emerge-puff coreboot and check system dmesg and evtest can get
device.

Change-Id: I070fb0e06b588f128253270502c9c2c427c62b84
Signed-off-by: Stanley Wu 
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 22 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47390/2

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47390

to look at the new patch set (#3).

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

mb/google/volteer/variant/lindar: Update devicetree settings for
touchscreen and trackpad

Update I2C address for Goodix touchscreen and add ELAN touchscreen &
Synaptics trackpad device. Follow CB:47415 to correct HID over I2C
device to be level triggerd.

BUG=b:160013582
TEST=emerge-puff coreboot and check system dmesg and evtest can get
device.

Change-Id: I070fb0e06b588f128253270502c9c2c427c62b84
Signed-off-by: Stanley Wu 
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 23 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47390/3

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
......................................................................

Patch Set 3: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@8 
PS3, Line 8: touchscreen and trackpad
drop this line, commit summary should be 72 chars or less

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@15 
PS3, Line 15: puff
emerge-volteer

Change in coreboot[master]: mb/google/volteer/variant/lindar: Update devicetree settings

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47390

to look at the new patch set (#4).

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings
......................................................................

mb/google/volteer/variant/lindar: Update devicetree settings

Update I2C address for Goodix touchscreen and add ELAN touchscreen &
Synaptics trackpad device. Follow CB:47415 to correct HID over I2C
device to be level triggerd.

BUG=b:160013582
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device.

Change-Id: I070fb0e06b588f128253270502c9c2c427c62b84
Signed-off-by: Stanley Wu 
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 23 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47390/4

Change in coreboot[master]: mb/google/volteer/variant/lindar: Update devicetree settings

[Stanley Wu (Code Review)]

Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings
......................................................................

Patch Set 4:

(5 comments)

https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47390/1//COMMIT_MSG@6 
PS1, Line 6: 
           : mb/google/volteer/variant/lindar: Update devicetree settings for touchscreen and trackpad
           : 
           : Update I2C address for Goodix touchscreen and add ELAN touchscreen & Synaptics trackpad.
           : 
           : BUG=b:160013582
           : TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
> Please keep all lines to 72 characters. […]

Done

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@8 
PS3, Line 8: touchscreen and trackpad
> drop this line, commit summary should be 72 chars or less

Done

https://review.coreboot.org/c/coreboot/+/47390/3//COMMIT_MSG@15 
PS3, Line 15: puff
> emerge-volteer

Done

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
PS1, Line 66: EDGE
> LEVEL, see CB:47415

Modify Line:45 as LEVEL instead of Line:66.

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
PS1, Line 88: EDGE
> LEVEL, see CB:47415

Done

Change in coreboot[master]: mb/google/volteer/variant/lindar: Update devicetree settings

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47390/1/src/mainboard/google/voltee... 
PS1, Line 66: EDGE
> Modify Line:45 as LEVEL instead of Line:66.

Oops yes you knew what I meant 😊

Change in coreboot[master]: mb/google/volteer/variant/lindar: Update devicetree settings

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47390 )

Change subject: mb/google/volteer/variant/lindar: Update devicetree settings
......................................................................

mb/google/volteer/variant/lindar: Update devicetree settings

Update I2C address for Goodix touchscreen and add ELAN touchscreen &
Synaptics trackpad device. Follow CB:47415 to correct HID over I2C
device to be level triggerd.

BUG=b:160013582
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device.

Change-Id: I070fb0e06b588f128253270502c9c2c427c62b84
Signed-off-by: Stanley Wu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47390
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 22 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index a318cca..64f5ab9 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -58,7 +58,19 @@
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
-				device i2c 14 on end
+				device i2c 5d on end
+			end
+			chip drivers/i2c/generic
+				register "hid" = ""ELAN0001""
+				register "desc" = ""ELAN Touchscreen""
+				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
+				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
+				register "reset_delay_ms" = "20"
+				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
+				register "enable_delay_ms" = "1"
+				register "has_power_resource" = "1"
+				device i2c 10 on end
    		end
    	end
    	device ref i2c5 on
@@ -70,6 +82,15 @@
    			register "probed" = "1"
    			device i2c 15 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)"
+				register "generic.wake" = "GPE0_DW2_15"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 0x2c on end
+			end
    	end
    	device ref north_xhci on
    		chip drivers/usb/acpi