Attention is currently required from: Martin Roth, Rex-BC Chen, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52542 )
Change subject: soc/mediatek/mt8195: Initialize watchdog
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/52542/comment/8e1b50a0_f7942bbb
PS1, Line 14: /*
: * On MT8195, the status register is cleared by writing this value to
: * the mode register. On MT8173/MT8183/MT8192, this value is invalid and
: * won't take effect.
: */
no need to have this comment since it's now controlled by the config.
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/52542/comment/691ebe10_99c95267
PS1, Line 18: config
you should move this config definition to src/soc/mediatek/common/Kconfig and only do "select" here, otherwise other non-8195 platforms may fail.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba5b41f426fc38719bb343a220e0724bff229c79
Gerrit-Change-Number: 52542
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 20 Apr 2021 14:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment