Change in coreboot[master]: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
ec/google/chromeec: Add .scan_bus() callback for Chrome EC device
This change adds scan_static_bus() as .scan_bus() callback for Chrome EC device which allows scanning of devices sitting behind the EC using the topology provided by mainboard's devicetree.cb.
BUG=b:154290952 TEST=Verified with follow up changes that devices behind EC are scanned correctly.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Id3630db56774fba1e3fc53bf349588c4c585773b --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40514/1
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 232df8e..bc8682b 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -439,6 +439,7 @@ .init = lpc_ec_init, .read_resources = lpc_ec_read_resources, .set_resources = noop_set_resources, + .scan_bus = scan_static_bus, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = google_chromeec_acpi_name, .acpi_fill_ssdt = google_chromeec_fill_ssdt_generator,
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG@14 PS1, Line 14: follow up follow-up
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG@15 PS1, Line 15: scanned Fits on line above?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG@14 PS1, Line 14: follow up
follow-up
Done
https://review.coreboot.org/c/coreboot/+/40514/1//COMMIT_MSG@15 PS1, Line 15: scanned
Fits on line above?
Done
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40514
to look at the new patch set (#3).
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
ec/google/chromeec: Add .scan_bus() callback for Chrome EC device
This change adds scan_static_bus() as .scan_bus() callback for Chrome EC device which allows scanning of devices sitting behind the EC using the topology provided by mainboard's devicetree.cb.
BUG=b:154290952 TEST=Verified with follow-up changes that devices behind EC are scanned correctly.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Id3630db56774fba1e3fc53bf349588c4c585773b --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40514/3
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 3: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
ec/google/chromeec: Add .scan_bus() callback for Chrome EC device
This change adds scan_static_bus() as .scan_bus() callback for Chrome EC device which allows scanning of devices sitting behind the EC using the topology provided by mainboard's devicetree.cb.
BUG=b:154290952 TEST=Verified with follow-up changes that devices behind EC are scanned correctly.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Id3630db56774fba1e3fc53bf349588c4c585773b Reviewed-on: https://review.coreboot.org/c/coreboot/+/40514 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Aaron Durbin: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 232df8e..bc8682b 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -439,6 +439,7 @@ .init = lpc_ec_init, .read_resources = lpc_ec_read_resources, .set_resources = noop_set_resources, + .scan_bus = scan_static_bus, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = google_chromeec_acpi_name, .acpi_fill_ssdt = google_chromeec_fill_ssdt_generator,
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40514 )
Change subject: ec/google/chromeec: Add .scan_bus() callback for Chrome EC device ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2535 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2534 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2533 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2532
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)