Attention is currently required from: Felix Singer, Harrie Paijmans.
Maxim Polyakov has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: superio/fintek: Add support for f81966d ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
File src/superio/fintek/f81966d/f81966d_gpio.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/475cd05a_bf5fb533?usp... : PS1, Line 14: */ space before */
https://review.coreboot.org/c/coreboot/+/87198/comment/73e245af_b06b8d84?usp... : PS1, Line 15: setreg set_reg to match the сode style
https://review.coreboot.org/c/coreboot/+/87198/comment/14f23a6d_84e9973c?usp... : PS1, Line 25: selectbank select_bank
https://review.coreboot.org/c/coreboot/+/87198/comment/7727e60f_163f3d11?usp... : PS1, Line 58: selectbank Do we really have to set a bank for each setreg()? Maybe we should do this when we switch between banks?
File src/superio/fintek/f81966d/superio.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/e16ffceb_8e406693?usp... : PS1, Line 58: Some of the 0x7f8 values may need to be corrected Mark it as `TODO: ...`?
-
Maxim Polyakov (Code Review)