Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62290 )
Change subject: soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26 MHz test
......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/mt8186/rtc.c:
https://review.coreboot.org/c/coreboot/+/62290/comment/03f3a7e5_649bafc2
PS6, Line 16: ((1 << 13) - (1 << 8))
Can we use the GENMASK() macro?
this definition is not used.
I remove them in this patch:
https://review.coreboot.org/c/coreboot/+/62457
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16ab46a5697d304e8001de231ffc9b7b7a2f9282
Gerrit-Change-Number: 62290
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 01 Mar 2022 03:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment