Attention is currently required from: Sean Rhodes.
Nicholas Sudsgaard has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84991?usp=email )
Change subject: soc/intel/common/cnvi: Nit - fix path in comment
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84991/comment/e45ce09f_be1bbf2d?usp... :
PS1, Line 7: Nit - fix path in comment
:
Giving a little bit more information in the title would be nice: "Fix GBTE path in comment".
nit: I don't think it's necessary to mention "Nit" in a commit message. 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84991?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1e5d70a23c2a139ef3ee4970db2e5d528c2661e
Gerrit-Change-Number: 84991
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Mon, 02 Dec 2024 14:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes