Change in coreboot[master]: mb/google/brask/variants/moli: init overridetree for moli - coreboot-gerrit

3 Mar 2022


      Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 )
Change subject: mb/google/brask/variants/moli: init overridetree for moli
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
...
+Subrata and Eric, any good suggestions for the panel face to put the ports on? this is a box/base design, not a laptop
I do suggest to use the same macro from here
https://review.coreboot.org/c/coreboot/+/61801/11/src/include/acpi/acpi_pld....
ACPI_PLD_TYPE_A(FRONT, CENTER, ACPI_PLD_GROUP(1, 1)) or 
ACPI_PLD_TYPE_A(BACK, CENTER, ACPI_PLD_GROUP(2, 1)) etc.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62321
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d
Gerrit-Change-Number: 62321
Gerrit-PatchSet: 8
Gerrit-Owner: Raihow Shi raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Peter Chi peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Mar 2022 06:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment