Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31464
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
drivers/intel/gma: Enable Kabylake+ libgfxinit support
Kaby, Coffee and Whiskey Lake are all supported by the same code path in libgfxinit.
TEST=Played Tint on clevo/kbl-u(n130bu).
Change-Id: Ic911bda3dd62c4d37a1b74a87fb51adc6c9d6ad4 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/intel/gma/Kconfig 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31464/1
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 4f897fa..2dbed01 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -68,7 +68,9 @@ depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \ || NORTHBRIDGE_INTEL_NEHALEM || NORTHBRIDGE_INTEL_SANDYBRIDGE \ || NORTHBRIDGE_INTEL_IVYBRIDGE || NORTHBRIDGE_INTEL_HASWELL \ - || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE + || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ + || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEE_LAKE \ + || SOC_INTEL_WHISKEY_LAKE depends on MAINBOARD_USE_LIBGFXINIT select RAMSTAGE_LIBHWBASE
@@ -88,6 +90,7 @@
config GFX_GMA_CPU string + default "Kabylake" if SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEE_LAKE || SOC_INTEL_WHISKEY_LAKE default "Broxton" if SOC_INTEL_APOLLOLAKE default "Skylake" if SOC_INTEL_SKYLAKE default "Broadwell" if SOC_INTEL_BROADWELL @@ -99,7 +102,10 @@
config GFX_GMA_CPU_VARIANT string - default "ULT" if (SOC_INTEL_SKYLAKE && !SKYLAKE_SOC_PCH_H) || SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL + default "ULT" if ((SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEY_LAKE) \ + && !SOC_INTEL_CANNONLAKE_PCH_H) \ + || ((SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE) && !SKYLAKE_SOC_PCH_H) \ + || SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL default "Normal"
config GFX_GMA_INTERNAL_PORT
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 1: Code-Review+2
Tested on KabyLake-R. Libgfxinit no longer prints "Incompatible CPU or PCH"
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31464/1/src/drivers/intel/gma/Kconfig File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/#/c/31464/1/src/drivers/intel/gma/Kconfig@72 PS1, Line 72: COFFEE_LAKE COFFEELAKE
https://review.coreboot.org/#/c/31464/1/src/drivers/intel/gma/Kconfig@73 PS1, Line 73: WHISKEY_LAKE WHISKEYLAKE
https://review.coreboot.org/#/c/31464/1/src/drivers/intel/gma/Kconfig@93 PS1, Line 93: COFFEE_LAKE || SOC_INTEL_WHISKEY_LAKE COFFEELAKE / WHISKEYLAKE
https://review.coreboot.org/#/c/31464/1/src/drivers/intel/gma/Kconfig@105 PS1, Line 105: WHISKEY_LAKE WHISKEYLAKE
Duncan Laurie has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
drivers/intel/gma: Enable Kabylake+ libgfxinit support
Kaby, Coffee and Whiskey Lake are all supported by the same code path in libgfxinit.
TEST=Played Tint on clevo/kbl-u(n130bu).
Change-Id: Ic911bda3dd62c4d37a1b74a87fb51adc6c9d6ad4 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/intel/gma/Kconfig 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31464/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31464/2/src/drivers/intel/gma/Kconfig File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/#/c/31464/2/src/drivers/intel/gma/Kconfig@105 PS2, Line 105: default "ULT" if (SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE) \ : && !SOC_INTEL_CANNONLAKE_PCH_H : default "ULT" if (SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE) && !SKYLAKE_SOC_PCH_H : default "ULT" if SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL : the lint checker did not seem to be able to handle nested parentheses so I split this into separate lines.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, Marcello Sylvester Bauer, Duncan Laurie, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, Jens Drenhaus,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31464
to look at the new patch set (#3).
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
drivers/intel/gma: Enable Kabylake+ libgfxinit support
Kaby, Coffee and Whiskey Lake are all supported by the same code path in libgfxinit.
TEST=Played Tint on clevo/kbl-u(n130bu).
Change-Id: Ic911bda3dd62c4d37a1b74a87fb51adc6c9d6ad4 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/drivers/intel/gma/Kconfig 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31464/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 3: Code-Review+2
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 3: Code-Review+2
testet on clevo kbl-u
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 4: Code-Review+2
LGTM
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 4: Code-Review+2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... PS5, Line 70: NORTHBRIDGE_INTEL_HASWELL any reason to have this on its own line? SOC vs NORTHBRIDGE? Seems like you could condense the following 3 lines into 2 if Broadwell moved up
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... PS5, Line 70: NORTHBRIDGE_INTEL_HASWELL
any reason to have this on its own line? SOC vs NORTHBRIDGE? […]
Just patch history. I guess that line contained IVYBRIDGE before, and I didn't want to increase patch noise when I removed it.
I can join the lines, if you prefer that, but don't really see a need :)
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/5/src/drivers/intel/gma/Kconf... PS5, Line 70: NORTHBRIDGE_INTEL_HASWELL
Just patch history. I guess that line contained IVYBRIDGE before, and […]
nah, was just being pedantic ;-)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 72: COFFEE_LAKE
COFFEELAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 73: WHISKEY_LAKE
WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 93: COFFEE_LAKE || SOC_INTEL_WHISKEY_LAKE
COFFEELAKE / WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/1/src/drivers/intel/gma/Kconf... PS1, Line 105: WHISKEY_LAKE
WHISKEYLAKE
Done
https://review.coreboot.org/c/coreboot/+/31464/2/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/31464/2/src/drivers/intel/gma/Kconf... PS2, Line 105: default "ULT" if (SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE) \ : && !SOC_INTEL_CANNONLAKE_PCH_H : default "ULT" if (SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE) && !SKYLAKE_SOC_PCH_H : default "ULT" if SOC_INTEL_BROADWELL || NORTHBRIDGE_INTEL_HASWELL :
the lint checker did not seem to be able to handle nested parentheses so I split this into separate […]
Gone
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31464 )
Change subject: drivers/intel/gma: Enable Kabylake+ libgfxinit support ......................................................................
drivers/intel/gma: Enable Kabylake+ libgfxinit support
Kaby, Coffee and Whiskey Lake are all supported by the same code path in libgfxinit.
TEST=Played Tint on clevo/kbl-u(n130bu).
Change-Id: Ic911bda3dd62c4d37a1b74a87fb51adc6c9d6ad4 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31464 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Thomas Heijligen src@posteo.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/gma/Kconfig 1 file changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Patrick Rudolph: Looks good to me, approved Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 59a9e8a..56c5d43 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -68,7 +68,9 @@ depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \ || NORTHBRIDGE_INTEL_NEHALEM || NORTHBRIDGE_INTEL_SANDYBRIDGE \ || NORTHBRIDGE_INTEL_HASWELL \ - || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE + || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ + || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE \ + || SOC_INTEL_WHISKEYLAKE depends on MAINBOARD_USE_LIBGFXINIT select RAMSTAGE_LIBHWBASE
@@ -94,7 +96,8 @@ config GFX_GMA_GENERATION string default "Broxton" if SOC_INTEL_APOLLOLAKE - default "Skylake" if SOC_INTEL_SKYLAKE + default "Skylake" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ + SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL default "Ironlake" if NORTHBRIDGE_INTEL_NEHALEM || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
-
Angel Pons (Code Review) -
Duncan Laurie (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Thomas Heijligen (Code Review)