Change in ...coreboot[master]: [WIP] 3rdparty/libgfxinit: Update submodule pointer

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

Nico Huber (Code Review)

18 Feb 2019 18 Feb '19

1:40 a.m.

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31457

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

[WIP] 3rdparty/libgfxinit: Update submodule pointer

Update libgfxinit:

o Add support for ULX (CPU Y series) variants o Add support for Kaby/Coffee/Whiskey/Amber Lakes o Publish Read_EDID() procedure

Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31457/1

diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index f70edda..47fa150 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit f70eddafbc2c6045a14e2f8bbb3273ee738fbaf7 +Subproject commit 47fa150df7ffee54659aebfdc78ff644ad319894

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Nico Huber (Code Review)

18 Feb 18 Feb

6:01 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31457

to look at the new patch set (#2).

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

[WIP] 3rdparty/libgfxinit: Update submodule pointer

Update libgfxinit:

o Add support for ULX (CPU Y series) variants o Add support for Kaby/Coffee/Whiskey/Amber Lakes o Publish Read_EDID() procedure

Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31457/2

Patrick Georgi (Code Review)

27 Mar 27 Mar

9:31 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31457 )

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

Patch Set 3:

what about this being WIP?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Mar 2019 08:31:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

12:14 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31457 )

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

Patch Set 3:

...

what about this being WIP?

Unmerged changes in libgfxinit. Can this wait one or two weeks? There is a longer queue atm. Alas, reviewing of the bigger topic:dyncpu_config has started now, so I wouldn't like to rebase that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Mar 2019 11:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:40 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31457 )

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

Patch Set 3:

...

Can this wait one or two weeks?

Sure, I just wanted to know what's going on here and avoid that everybody's waiting for somebody else.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Mar 2019 11:40:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

10 May 10 May

5:18 p.m.

Hello Duncan Laurie, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31457

to look at the new patch set (#4).

Change subject: [WIP] 3rdparty/libgfxinit: Update submodule pointer ......................................................................

[WIP] 3rdparty/libgfxinit: Update submodule pointer

Update libgfxinit:

o Add support for ULX (CPU Y series) variants o Add support for Kaby/Coffee/Whiskey/Amber Lakes o Publish Read_EDID() procedure

Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31457/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

3 Aug 3 Aug

7:24 p.m.

New subject: Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer

Hello Duncan Laurie, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31457

to look at the new patch set (#6).

Change subject: 3rdparty/libgfxinit: Update submodule pointer ......................................................................

3rdparty/libgfxinit: Update submodule pointer

Update libgfxinit:

o Add support for ULX (CPU Y series) variants o Add support for Kaby/Coffee/Whiskey/Amber Lakes o Publish Read_EDID() procedure o Fix certain GMBUS error conditions o Fix DP training when clock recovery needed voltage-swing increase o Fix scaling on eDP for BDW+

Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Signed-off-by: Nico Huber nico.h@gmx.de --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/31457/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Matt DeVillier (Code Review)

7:43 p.m.

New subject: Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31457 )

Change subject: 3rdparty/libgfxinit: Update submodule pointer ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 03 Aug 2019 17:43:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5 Aug 5 Aug

10:24 a.m.

New subject: Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31457 )

Change subject: 3rdparty/libgfxinit: Update submodule pointer ......................................................................

3rdparty/libgfxinit: Update submodule pointer

Update libgfxinit:

Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/31457 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M 3rdparty/libgfxinit 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved

diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index b3b9fa3..a815704 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit b3b9fa34bb99d33d0fc6a69c64966a71cebd5bd6 +Subproject commit a815704c84b4823f5b723404a37efed9d6c85d66

-- To view, visit https://review.coreboot.org/c/coreboot/+/31457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib252303708d2bb0524ecc47f498df45902ba774f Gerrit-Change-Number: 31457 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1734

days inactive

1902

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Matt DeVillier (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)