Attention is currently required from: Jon Murphy, Paul Menzel.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62165 )
Change subject: mb/google/skyrim: Configure WLAN
......................................................................
Patch Set 30:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/62165/comment/b2703d38_324ee442
PS30, Line 161: WLAN_DISABLE
Should we set this in the early table as well?
https://review.coreboot.org/c/coreboot/+/62165/comment/fd678379_c2189cad
PS30, Line 180: PAD_NFO
Hrmm, I thought we were deasserting this in the early table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16e35b443f741d366589fefb7fd21863369d1ec2
Gerrit-Change-Number: 62165
Gerrit-PatchSet: 30
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 08 Mar 2022 15:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment