Change in coreboot[master]: drivers/intel/fsp1_1: Drop empty weak functions

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54957 )

Change subject: drivers/intel/fsp1_1: Drop empty weak functions
......................................................................

drivers/intel/fsp1_1: Drop empty weak functions

The only FSP 1.1 platform is Braswell. Drop unnecessary functions which
only have a weak stub definition.

Change-Id: Ie60213e5a6ae67bd8b982ee505f4b512253577c6
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54957
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
---
M src/drivers/intel/fsp1_1/include/fsp/ramstage.h
M src/drivers/intel/fsp1_1/include/fsp/romstage.h
M src/drivers/intel/fsp1_1/ramstage.c
M src/drivers/intel/fsp1_1/romstage.c
4 files changed, 0 insertions(+), 31 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/drivers/intel/fsp1_1/include/fsp/ramstage.h b/src/drivers/intel/fsp1_1/include/fsp/ramstage.h
index d1b803e..77698f2 100644
--- a/src/drivers/intel/fsp1_1/include/fsp/ramstage.h
+++ b/src/drivers/intel/fsp1_1/include/fsp/ramstage.h
@@ -8,8 +8,6 @@

/* Perform Intel silicon init. */
 void intel_silicon_init(void);
-/* Called after the silicon init code has run. */
-void soc_after_silicon_init(void);
 /* Initialize UPD data before SiliconInit call. */
 void soc_silicon_init_params(SILICON_INIT_UPD *params);
 void mainboard_silicon_init_params(SILICON_INIT_UPD *params);
diff --git a/src/drivers/intel/fsp1_1/include/fsp/romstage.h b/src/drivers/intel/fsp1_1/include/fsp/romstage.h
index 99dd9b8..4234ed5 100644
--- a/src/drivers/intel/fsp1_1/include/fsp/romstage.h
+++ b/src/drivers/intel/fsp1_1/include/fsp/romstage.h
@@ -29,9 +29,6 @@
    MEMORY_INIT_UPD *memory_params);
 void mainboard_pre_raminit(struct romstage_params *params);
 void mainboard_save_dimm_info(struct romstage_params *params);
-void mainboard_add_dimm_info(struct romstage_params *params,
-			     struct memory_info *mem_info,
-			     int channel, int dimm, int index);
 void raminit(struct romstage_params *params);
 /* Initialize memory margin analysis settings. */
 void setup_mma(MEMORY_INIT_UPD *memory_upd);
@@ -40,7 +37,6 @@
    MEMORY_INIT_UPD *new);
 void soc_memory_init_params(struct romstage_params *params,
    		    MEMORY_INIT_UPD *upd);
-void soc_pre_ram_init(struct romstage_params *params);
 void mainboard_after_memory_init(void);

#endif /* _COMMON_ROMSTAGE_H_ */
diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c
index 3ae473b..dcb32c7 100644
--- a/src/drivers/intel/fsp1_1/ramstage.c
+++ b/src/drivers/intel/fsp1_1/ramstage.c
@@ -13,11 +13,6 @@
 #include <timestamp.h>
 #include <cbmem.h>

-/* SOC initialization after FSP silicon init */
-__weak void soc_after_silicon_init(void)
-{
-}
-
 static void display_hob_info(FSP_INFO_HEADER *fsp_info_header)
 {
    const EFI_GUID graphics_info_guid = EFI_PEI_GRAPHICS_INFO_HOB_GUID;
@@ -141,7 +136,6 @@
    }

display_hob_info(fsp_info_header);
-	soc_after_silicon_init();
 }

static void fsp_load(void)
diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c
index 01d186f..ff03805 100644
--- a/src/drivers/intel/fsp1_1/romstage.c
+++ b/src/drivers/intel/fsp1_1/romstage.c
@@ -33,8 +33,6 @@

elog_boot_notify(s3wake);

-	/* Perform remaining SOC initialization */
-	soc_pre_ram_init(params);
    post_code(0x33);

/* Check recovery and MRC cache */
@@ -258,10 +256,6 @@
    					MEMORY_BUS_WIDTH_128;
    				break;
    			}
-
-				/* Add any mainboard specific information */
-				mainboard_add_dimm_info(params, mem_info,
-							channel, dimm, index);
    			index++;
    		}
    	}
@@ -269,16 +263,3 @@
    mem_info->dimm_cnt = index;
    printk(BIOS_DEBUG, "%d DIMMs found\n", mem_info->dimm_cnt);
 }
-
-/* Add any mainboard specific information */
-__weak void mainboard_add_dimm_info(
-	struct romstage_params *params,
-	struct memory_info *mem_info,
-	int channel, int dimm, int index)
-{
-}
-
-/* SOC initialization before RAM is enabled */
-__weak void soc_pre_ram_init(struct romstage_params *params)
-{
-}