Attention is currently required from: Bora Guvendik, Anil Kumar K, Jeremy Compostella, Subrata Banik, Tim Wawrzynczak.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63942 )
Change subject: soc/intel/alderlake: support for PCIe slot & device detect timeout
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63942/comment/c683b338_8904cb50
PS6, Line 671: if (!!(rp_cfg->flags & PCIE_RP_BUILT_IN))
double negation is unnecessary in a if statement. […]
double negation has been used in several places. also, in if-conditions. if-condition is used here only update when different from FSP default.
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/63942/comment/8dc5b8bd_45f078dd
PS6, Line 30: /* indicates that this root port is built-in */
missing ending dot character.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13feb1d2d67eaba634a3e700685132fba39e1525
Gerrit-Change-Number: 63942
Gerrit-PatchSet: 7
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 20:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-MessageType: comment