[S] Change in coreboot[main]: mb/google/brox/var/jubilant: Add fw_config for WWAN Sar Sensor - coreboot-gerrit

12 Nov 2024


      Attention is currently required from: David Wu, Karthik Ramasubramanian, Kenneth Chan, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85107?usp=email )
Change subject: mb/google/brox/var/jubilant: Add fw_config for WWAN Sar Sensor
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85107/comment/06b63722_6b86a889?usp... :
PS2, Line 14: smm-y-$(CONFIG_FW_CONFIG)
...
smm-$(CONFIG_FW_CONFIG)
This will cause build error!
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If9231ac8df94e1dc514ecf0780c99adbfb902893
Gerrit-Change-Number: 85107
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Richard Lin richardlin@quanta.corp-partner.google.com
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 13 Nov 2024 02:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com