Change in coreboot[master]: mb/google/hatch: Remove pen device for dratini/dragonair

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

mb/google/hatch: Remove pen device for dratini/dragonair

Dratini/Dragonair doesn't support pen insertion/ejection feature,
so remove it.

BUG=b:142159117
TEST=emerge-hatch coreboot

Change-Id: I64859a162d8dc75ffe55d98b72a056dd72e8de75
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/hatch/variants/dratini/overridetree.cb
1 file changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/35844/1

diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
index 65649d1..351c82b 100644
--- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
@@ -105,17 +105,6 @@
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 5d on end
    		end
-			chip drivers/generic/gpio_keys
-				register "name" = ""PENH""
-				register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"
-				register "key.wake" = "GPE0_DW0_08"
-				register "key.wakeup_event_action" = "EV_ACT_ASSERTED"
-				register "key.dev_name" = ""EJCT""
-				register "key.linux_code" = "SW_PEN_INSERTED"
-				register "key.linux_input_type" = "EV_SW"
-				register "key.label" = ""pen_eject""
-				device generic 0 on end
-			end
    	end # I2C #1
    	device pci 15.2 off end # I2C #2
    	device pci 15.3 off end # I2C #3

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1: Code-Review+2

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
PS1, Line 110: GPP_A8
Do you need to modify GPP_A8 in gpio.c as well?

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
PS1, Line 110: GPP_A8
> Do you need to modify GPP_A8 in gpio. […]

It's already NC in gpio.c

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/dratini/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35844/1/src/mainboard/google/hatch/... 
PS1, Line 110: GPP_A8
> It's already NC in gpio. […]

Ah, thanks for looking into that Tim!

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35844 )

Change subject: mb/google/hatch: Remove pen device for dratini/dragonair
......................................................................

mb/google/hatch: Remove pen device for dratini/dragonair

Dratini/Dragonair doesn't support pen insertion/ejection feature,
so remove it.

BUG=b:142159117
TEST=emerge-hatch coreboot

Change-Id: I64859a162d8dc75ffe55d98b72a056dd72e8de75
Signed-off-by: Wisley Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35844
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Shelley Chen 
---
M src/mainboard/google/hatch/variants/dratini/overridetree.cb
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Shelley Chen: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
index 1af822d4..f1e8239 100644
--- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb
@@ -105,17 +105,6 @@
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 5d on end
    		end
-			chip drivers/generic/gpio_keys
-				register "name" = ""PENH""
-				register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"
-				register "key.wake" = "GPE0_DW0_08"
-				register "key.wakeup_event_action" = "EV_ACT_ASSERTED"
-				register "key.dev_name" = ""EJCT""
-				register "key.linux_code" = "SW_PEN_INSERTED"
-				register "key.linux_input_type" = "EV_SW"
-				register "key.label" = ""pen_eject""
-				device generic 0 on end
-			end
    	end # I2C #1
    	device pci 15.2 off end # I2C #2
    	device pci 15.3 off end # I2C #3