Change in coreboot[master]: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml
Bernardo Perez Priego has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
mb/google/drallion: Enable UART console for arcada_cml and sarien_cml
Drallion uses UART 0 for console, other two variants remain as UART 2.
BUG=b:139095062 TEST="emerge-drallion coreboot chromeos-bootimage. Console should be visible"
Change-Id: I520a07ad6f755bc2e6481329fc69bef9a36e31e2 Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/35785/1
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 35f7150..256f8cb 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -84,7 +84,9 @@
config UART_FOR_CONSOLE int - default 0 + default 2 if BOARD_GOOGLE_ARCADA_CML + default 2 if BOARD_GOOGLE_SARIEN_CML + default 0 if BOARD_GOOGLE_DRALLION
config VARIANT_DIR string
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG@12 PS1, Line 12: " not needed
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG@13 PS1, Line 13: " Not needed, put a . instead
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 1: Code-Review+1
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 1: Code-Review+2
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 1: Code-Review+2
Hello EricR Lai, Angel Pons, Aamir Bohra, Mathew King, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Patrick Georgi, Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35785
to look at the new patch set (#2).
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
mb/google/drallion: Enable UART console for arcada_cml and sarien_cml
Drallion uses UART 0 for console, other two variants remain as UART 2.
BUG=b:139095062 TEST=emerge-drallion coreboot chromeos-bootimage. Console should be visible.
Change-Id: I520a07ad6f755bc2e6481329fc69bef9a36e31e2 Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/35785/2
Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG@12 PS1, Line 12: "
not needed
Done
https://review.coreboot.org/c/coreboot/+/35785/1//COMMIT_MSG@13 PS1, Line 13: "
Not needed, put a . […]
Done
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35785 )
Change subject: mb/google/drallion: Enable UART console for arcada_cml and sarien_cml ......................................................................
mb/google/drallion: Enable UART console for arcada_cml and sarien_cml
Drallion uses UART 0 for console, other two variants remain as UART 2.
BUG=b:139095062 TEST=emerge-drallion coreboot chromeos-bootimage. Console should be visible.
Change-Id: I520a07ad6f755bc2e6481329fc69bef9a36e31e2 Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35785 Reviewed-by: Bora Guvendik bora.guvendik@intel.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved Aamir Bohra: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 35f7150..256f8cb 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -84,7 +84,9 @@
config UART_FOR_CONSOLE int - default 0 + default 2 if BOARD_GOOGLE_ARCADA_CML + default 2 if BOARD_GOOGLE_SARIEN_CML + default 0 if BOARD_GOOGLE_DRALLION
config VARIANT_DIR string
-
Aamir Bohra (Code Review) -
Angel Pons (Code Review)
-
Bernardo Perez Priego (Code Review)
-
Bora Guvendik (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)