Ran Bi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31508
Change subject: google/kukui: Support RTC initialization ......................................................................
google/kukui: Support RTC initialization
This patch initialize rtc module.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui
Change-Id: I9d9c68755e8a6ac65dd794211e6ccf06e5057567 Signed-off-by: Ran Bi ran.bi@mediatek.com --- M src/mainboard/google/kukui/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/31508/1
diff --git a/src/mainboard/google/kukui/romstage.c b/src/mainboard/google/kukui/romstage.c index 629692d..f4d1e8e 100644 --- a/src/mainboard/google/kukui/romstage.c +++ b/src/mainboard/google/kukui/romstage.c @@ -17,10 +17,12 @@ #include <soc/emi.h> #include <soc/mmu_operations.h> #include <soc/mt6358.h> +#include <soc/rtc.h>
void platform_romstage_main(void) { mt6358_init(); + rtc_boot(); mt_mem_init(get_sdram_config()); mtk_mmu_after_dram(); }
Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31508 )
Change subject: google/kukui: Support RTC initialization ......................................................................
Patch Set 1: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31508 )
Change subject: google/kukui: Support RTC initialization ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31508/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31508/1//COMMIT_MSG@7 PS1, Line 7: Support Add
https://review.coreboot.org/#/c/31508/1//COMMIT_MSG@9 PS1, Line 9: This patch initialize rtc module. Initialize RTC at ROM stage.
Hello You-Cheng Syu, Paul Menzel, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31508
to look at the new patch set (#2).
Change subject: google/kukui: Add RTC initialization ......................................................................
google/kukui: Add RTC initialization
Initialize RTC at ROM stage.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui
Change-Id: I9d9c68755e8a6ac65dd794211e6ccf06e5057567 Signed-off-by: Ran Bi ran.bi@mediatek.com --- M src/mainboard/google/kukui/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/31508/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31508 )
Change subject: google/kukui: Add RTC initialization ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31508 )
Change subject: google/kukui: Add RTC initialization ......................................................................
google/kukui: Add RTC initialization
Initialize RTC at ROM stage.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui
Change-Id: I9d9c68755e8a6ac65dd794211e6ccf06e5057567 Signed-off-by: Ran Bi ran.bi@mediatek.com Reviewed-on: https://review.coreboot.org/c/31508 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/romstage.c b/src/mainboard/google/kukui/romstage.c index 7aad11f..7d0e9c2 100644 --- a/src/mainboard/google/kukui/romstage.c +++ b/src/mainboard/google/kukui/romstage.c @@ -17,6 +17,7 @@ #include <soc/emi.h> #include <soc/mmu_operations.h> #include <soc/mt6358.h> +#include <soc/rtc.h>
#include "early_init.h"
@@ -27,6 +28,7 @@ mainboard_early_init();
mt6358_init(); + rtc_boot(); mt_mem_init(get_sdram_config()); mtk_mmu_after_dram(); }