Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58769 )
Change subject: mb/google/brya: Correct AT24 NVM address size ......................................................................
mb/google/brya: Correct AT24 NVM address size
Currently, the address size field of AT24 NVM is incorrect, and Linux v5.10 kernel logs the message below:
at24 i2c-PRP0001:01: Bad "address-width" property: 14
The valid size of the AT24 NVM is 16 bits so modify the value from 0x0E to 0x10.
TEST=Boot brya and check the kernel log and see "Bad address-width" error message is not shown.
Signed-off-by: Varshit B Pandya varshit.b.pandya@intel.com Change-Id: I6c1ed5334396e0ca09ea0078426a7b5039ae4e8b Reviewed-on: https://review.coreboot.org/c/coreboot/+/58769 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/mainboard/google/brya/variants/brya0/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve EricR Lai: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index f3b7925..0052d90 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -320,7 +320,7 @@ register "nvm_size" = "0x2800" register "nvm_pagesize" = "0x01" register "nvm_readonly" = "0x01" - register "nvm_width" = "0x0E" + register "nvm_width" = "0x10"
device i2c 58 on end end
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.