Attention is currently required from: Angel Pons, Jérémy Compostella, Keith Hui, Martin L Roth, Martin Roth, Paul Menzel.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79093?usp=email )
Change subject: nb/intel/sandybridge: Fix unitialized variable issue
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The 4.22 tag was done roughly 13 hours before your comment. If we you feel like we want to do a 4. […]
The question I want to ask is: What is the chance of a boot failure because of an incorrect value here, because this isn't initialized?
I am not sure how uninitialized memory can manifest itself in CAR.
Scope of issue: This affects boards that say in Kconfig to HAVE_SPD_IN_CBFS, but didn't actually flag any DIMM positions as SPD_MEMORY_DOWN. I made pretty sure no board does this. If anything else warrants a 4.22.1, this patch then should be included, but any new SNB/IVB boards that set things up correctly should not trigger the bug.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79093?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539
Gerrit-Change-Number: 79093
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Sun, 19 Nov 2023 06:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment