Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Angel Pons, Fred Reitberger, Patrick Rudolph, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55067 )
Change subject: arch/x86: Add a common romstage entry
......................................................................
Patch Set 7:
(3 comments)
File src/arch/x86/romstage.c:
https://review.coreboot.org/c/coreboot/+/55067/comment/6ba17d01_1907e636
PS5, Line 8: /* Provide an entry point for verstage when it's a separate stage. */
verstage?
Done
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/55067/comment/ab33138f_ebe3a7da
PS5, Line 4: #include <acpi/acpi.h>
: #include <amdblocks/acpimmio.h>
: #include <amdblocks/memmap.h>
: #include <amdblocks/pmlib.h>
: #include <arch/cpu.h>
: #include <console/console.h>
: #include <fsp/api.h>
: #include <program_loading.h>
: #include <timestamp.h>
Looks like these includes are sorted alphabetically. […]
Done
https://review.coreboot.org/c/coreboot/+/55067/comment/b3e9b833_ce3c8bec
PS5, Line 16: timestamp_add_now(TS_START_ROMSTAGE);
This needs to be removed
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4968364a95b5c69c21d3915d302d23e6f1ca182f
Gerrit-Change-Number: 55067
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 06 Apr 2022 20:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment