Isaac Christensen (isaac.christensen@se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6962
-gerrit
commit 84378b19a334ae81e49e103d1721477275066da4 Author: Stefan Reinauer reinauer@chromium.org Date: Mon Mar 3 15:08:10 2014 -0800
google/panther: Be safe about invalid thermal readings
In case we get an invalid thermal reading, let's run the fan at full speed rather than at low speed. This might impact the user experiance slightly in cases where the bad reading does not happen while the system is hot, but it will increase stability in the cases where the system is actually overheating.
Also, set the critical temperature below tjmax, because otherwise thermal shutdown by the OS will never be triggered.
Signed-off-by: Stefan Reinauer reinauer@google.com
Change-Id: Iab262f1f17a5dff875c596d9e8d50e4e50ee90f9 Reviewed-on: https://chromium-review.googlesource.com/188556 Reviewed-by: Shawn Nematbakhsh shawnn@chromium.org Commit-Queue: Stefan Reinauer reinauer@chromium.org Tested-by: Stefan Reinauer reinauer@chromium.org (cherry picked from commit 721fc2361ea9c6fea75409be57726294ce840f03) Signed-off-by: Isaac Christensen isaac.christensen@se-eng.com --- src/mainboard/google/panther/acpi/thermal.asl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/google/panther/acpi/thermal.asl b/src/mainboard/google/panther/acpi/thermal.asl index 72b4ad8..3a1f7be 100644 --- a/src/mainboard/google/panther/acpi/thermal.asl +++ b/src/mainboard/google/panther/acpi/thermal.asl @@ -76,12 +76,12 @@ Scope (_TZ)
// Check for "no reading available" If (LEqual (Local0, 0x80)) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) }
// Check for invalid readings If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) }
// PECI raw value is an offset from Tj_max