Attention is currently required from: Henry Sun, Super Ni, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62729 )
Change subject: mb/google/dedede: Update DPTF setting ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62729/comment/75bb75f0_100d62c5 PS1, Line 10: we remove unused temperature sensors according to : mainboard schematic
I do not see anything removed in the devicetree diff.
Hi Paul,
Thank you for your advice. I reference baseboard dptf setting (https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...) as my initial dptf values. After I check hardware schematic, I find out that the TEMP_SENSOR_2 is not existing. Therefore, I remove non-existing temeprature sensor. This CL is the modified result. As a result, I update commit message.
https://review.coreboot.org/c/coreboot/+/62729/comment/4bb69c8e_09a83e85 PS1, Line 17: cat /sys/class/thermal/thermal_zone*/type
For the future you can use `grep -R . […]
Hi Paul,
Thank you for your advice. I run the command and get result with zone number: localhost ~ # grep -R . /sys/class/thermal/thermal_zone*/type /sys/class/thermal/thermal_zone0/type:x86_pkg_temp /sys/class/thermal/thermal_zone1/type:INT3400 Thermal /sys/class/thermal/thermal_zone2/type:TSR0 /sys/class/thermal/thermal_zone3/type:TSR1 /sys/class/thermal/thermal_zone4/type:TCPU
-
Teddy Shih (Code Review)