Attention is currently required from: Arthur Heymans, Michael Büchler, Nicholas Chin, Nico Huber, Paul Menzel, ilikenwf, nat ✨.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 33:
(4 comments)
File src/mainboard/dell/optiplex_9020/Kconfig:
https://review.coreboot.org/c/coreboot/+/55232/comment/69b3d83e_9fcd40fc :
PS32, Line 10: select HAVE_OPTION_TABLE
: select HAVE_CMOS_DEFAULT
Swap these to keep the list in alphabetical order
Done
File src/mainboard/dell/optiplex_9020/board_info.txt:
https://review.coreboot.org/c/coreboot/+/55232/comment/bd45796b_9aaa584d :
PS32, Line 3: 2014
Nit: The 9020 seems to have been released in 2013 and the 7020 in 2014
Done
File src/mainboard/dell/optiplex_9020/cmos.default:
PS32:
Needs an SPDX header, refer to commit e623845df6 (mb/*: Add SPDX headers for cmos. […]
Done
File src/mainboard/dell/optiplex_9020/romstage.c:
https://review.coreboot.org/c/coreboot/+/55232/comment/9833b862_b84318dc :
PS32, Line 3: #include <northbridge/intel/haswell/haswell.h>
This doesn't seem to be necessary. Seems to build fine if I remove it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 33
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Westover
me@benthetechguy.net
Gerrit-CC: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: ilikenwf
mparnell@gmail.com
Gerrit-CC: nat ✨
nat@nekopon.pl
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: nat ✨
nat@nekopon.pl
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: ilikenwf
mparnell@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Michael Büchler
michael.buechler@posteo.net
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment