build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28640 )
Change subject: mb/clevo/n130wu: Add mainboard ......................................................................
Patch Set 66:
(4 comments)
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/gpio.h File src/mainboard/clevo/n130wu/gpio.h:
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/gpio.h@1... PS66, Line 168: /* I2C5_SDA/ISH_I2C2_SDA */ _PAD_CFG_STRUCT(GPP_F10, 0x44000b02, 0x2000000), line over 80 characters
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/gpio.h@1... PS66, Line 169: /* I2C5_SCL/ISH_I2C2_SCL */ _PAD_CFG_STRUCT(GPP_F11, 0x44000b02, 0x2000000), line over 80 characters
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/pei_data... File src/mainboard/clevo/n130wu/pei_data.c:
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/pei_data... PS66, Line 31: 0x33, 0x00, 0xFF, 0x00, 0xFF, 0x00}}; space required after that close brace '}'
https://review.coreboot.org/#/c/28640/66/src/mainboard/clevo/n130wu/pei_data... PS66, Line 40: {1, 0, 4, 5, 2, 3, 6, 7}}; space required after that close brace '}'