Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29667 )
Change subject: mb/emulation/qemu-q35,qemu-i440fx: Add x86_64 support ......................................................................
Patch Set 39:
(6 comments)
https://review.coreboot.org/c/coreboot/+/29667/32/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-q35.md:
https://review.coreboot.org/c/coreboot/+/29667/32/Documentation/mainboard/em... PS32, Line 42: operating system
and -bios for what matters.
Done
https://review.coreboot.org/c/coreboot/+/29667/4/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/29667/4/src/arch/x86/Kconfig@334 PS4, Line 334: config TTB_SIZE_KB
Note that TTB is very Arm-specific lingo, you might want to go with something else.
this isn't present in the latest revision
https://review.coreboot.org/c/coreboot/+/29667/4/src/arch/x86/mmu.c File src/arch/x86/mmu.c:
https://review.coreboot.org/c/coreboot/+/29667/4/src/arch/x86/mmu.c@255 PS4, Line 255: GRANULE_SIZE
I looked into the manual already, but I find L0/L1/L2/L3 much easier to understand. […]
this isn't present in the latest revision
https://review.coreboot.org/c/coreboot/+/29667/4/src/arch/x86/mmu.c@297 PS4, Line 297: /* Func : assert_correct_ttb_mapping
I think it's still necessary. […]
this isn't present in the latest revision
https://review.coreboot.org/c/coreboot/+/29667/4/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/c/coreboot/+/29667/4/src/include/memlayout.h@26 PS4, Line 26: #define ARCH_POINTER_ALIGN_SIZE 16
No, it's a workaround to fix the __cpu_driver. […]
this isn't present in the latest revision
https://review.coreboot.org/c/coreboot/+/29667/15/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/c/coreboot/+/29667/15/src/mainboard/emulation/qe... PS15, Line 48: * configure MTRRs here as on real hardware.
I don't see the connection in requiring MTRRs to be setup to be able to use page-tables.
removed the romstage code, this comment no longer applies
-
Patrick Rudolph (Code Review)