Attention is currently required from: Matt DeVillier, Nick Vaccaro.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79960?usp=email )
Change subject: intel tgl mainboards: Move PcieRpEnable option below dt entries
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/volteer/variants/voema/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79960/comment/d51c7521_21ef22a8 :
PS1, Line 108: probe DB_SD SD_GL9755S
: probe DB_SD SD_RTS5261
: probe DB_SD SD_RTS5227S
: probe DB_SD SD_GL9750
: probe DB_SD SD_OZ711LV2LN
it shouldn't, especially when disabling a previously-enabled device. […]
Removed the entries but it broke the build. I'm unsure if they need to be added though, but it's my guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79960?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65bf27342191129b433d779774e084eecb4e4b3e
Gerrit-Change-Number: 79960
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 15 Jan 2024 20:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment