Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67533 )
Change subject: soc/intel/common: Update comment on HFSTS1.spi_protection_mode ......................................................................
soc/intel/common: Update comment on HFSTS1.spi_protection_mode
The patch updates comment on HFSTS1.spi_protection_mode. The spi_protection_mode indicates SPI protection status as well as EOM status (in a single staged EOM flow). Starting from TGL platform, staged EOM flow is introduced. In this flow, spi_protection_mode alone doesn't indicate the EOM status.
For information on EOM status, please refer secton# 3.6.1 in doc# 612229.
TEST=Build code for Gimble
Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Change-Id: I19df5cfaa6d49963bbfb3f8bc692d847e58c4420 --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 28 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/67533/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index a68c982..f4f119b 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -271,12 +271,14 @@ }
/* - * TGL HFSTS1.spi_protection_mode bit replaces the previous - * `manufacturing mode (mfg_mode)` without changing the offset and purpose - * of this bit. + * Starting from TGL platform, HFSTS1.spi_protection_mode replaces mfg_mode to indiciate + * SPI protection status as well as end-of-manufacturing(EOM) status where EOM flow is + * triggered in single staged operation (either through first boot with required MFIT + * configuratin or FPT /CLOSEMANUF). + * In staged manufacturing flow, spi_protection_mode alone doesn't indicate the EOM status. * - * Using HFSTS1.mfg_mode to get the SPI protection status for all PCH. - * mfg_mode = 0 means SPI protection in on. + * HFSTS1.spi_protection_mode description: + * mfg_mode = 0 means SPI protection is on. * mfg_mode = 1 means SPI is unprotected. */ bool cse_is_hfs1_spi_protected(void)