Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )
Change subject: soc/mediatek: Add PCIe support
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/1554e65c_52fefde3
PS6, Line 285: ret = mtk_pcie_startup_port(ctrl);
: if (ret)
: return;
Rewrite as
if (mtk_pcie_startup_port(ctrl) < 0)
return;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
Gerrit-Change-Number: 56791
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 08:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment