Change in ...coreboot[master]: mb/lenovo/t430: Fix Dual Graphics

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33254

Change subject: mb/lenovo/t430: Fix Dual Graphics
......................................................................

mb/lenovo/t430: Fix Dual Graphics

Select ONBOARD_VGA_IS_PRIMARY to fix disabling iGPU in Dual Graphics.

Change-Id: I6594fbb957c9a8135fe670d38b5755adf29d2dff
Signed-off-by: Patrick Rudolph 
---
M src/mainboard/lenovo/t430/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/33254/1

diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig
index 7137b5e..a9e5815 100644
--- a/src/mainboard/lenovo/t430/Kconfig
+++ b/src/mainboard/lenovo/t430/Kconfig
@@ -49,4 +49,9 @@
 config USBDEBUG_HCD_INDEX
    int
    default 2
+
+config ONBOARD_VGA_IS_PRIMARY
+	bool
+	default y
+
 endif

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33254 )

Change subject: mb/lenovo/t430: Fix Dual Graphics
......................................................................

Patch Set 1:

did you also test the option to have only the internal or the nvidia gpu active?

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33254 )

Change subject: mb/lenovo/t430: Fix Dual Graphics
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33254/1/src/mainboard/lenovo/t430/Kconfig 
File src/mainboard/lenovo/t430/Kconfig:

https://review.coreboot.org/#/c/33254/1/src/mainboard/lenovo/t430/Kconfig@23 
PS1, Line 23: DRIVERS_LENOVO_HYBRID_GRAPHICS
Would it make sense to select in there given that this is more or less the expected behaviour?

[Patrik Tesarik (Code Review)]

Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33254 )

Change subject: mb/lenovo/t430: Fix Dual Graphics
......................................................................

Patch Set 1:
> Patch Set 1:
>
> did you also test the option to have only the internal or the nvidia gpu active?

I've tested the patched option in the different bios settings and describe the corresponding behavior in the following.

Integrated Only:

If no external VGA display is connected, payload (SeaBIOS) is displayed on internal screen.

If external VGA display is connected, internal screen is deactivated and payload (SeaBIOS) is displayed on the external display.

After successful kernel boot both displays are active. But internal display is distorted. Distortion may be results of competing graphics initialisation between Coreboot and SeaBIOS and will be tested in the next step.

Discrete Only:

In either scenario, external connection via mDP and internal display only, the output (payload stage up to kernel initialisation) is send to the internal display. But login is prompted on both, external and internal, displays with no distortion.

Dual graphics:

Same as Discrete Only.