Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26169 )
Change subject: devicetree: Add USB device type ......................................................................
Patch Set 3:
(1 comment)
Stumbled upon this code while I was looking for something in dev_path_encode. Thought about checking here.
https://review.coreboot.org/c/coreboot/+/26169/3/src/device/device_util.c File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/26169/3/src/device/device_util.c@26... PS3, Line 260: || Did you intend to use bit-wise OR or logical OR. Seems inconsistent with the rest of the dev_path_encode logic. I can fix it if you intend to use bit-wise OR. Currently used only in the POST Log.
-
Karthik Ramasubramanian (Code Review)