[S] Change in coreboot[master]: acpi: Add function to print debug string directly from formatted string
Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Jakub Czapiga, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 )
Change subject: acpi: Add function to print debug string directly from formatted string ......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/73113/comment/3e32cea5_d2dd9fb4 PS2, Line 508: acpigen_write_debug
Okay. Let me spend some time and come back on this.
okay. I will change the function name to acpigen_write_debug_sprintf().
The purpose of this function is to resolve the string that can be finalized in the C side rather than deferring to ACPI so that Concatenate() won't be needed. For the messages that contains the value from the Objects, like Local[n], Arg[n], and Name objects, ACPI Concatenate() will still be needed to construct the final string. ACPI Printf() can be used for this purpose. However, it is a micro and it does not have OP code. acpigen won't be able to expand the macro into proper nested Concatenate() functions and final Debug() based on its 'fmt' string format.
We could still use Fprintf() and Printf() in .asl source files for DSDT. The decoded .dsl will have the expanded Concatenate() and Debug() functions instead.
-
Cliff Huang (Code Review)