Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25082 )
Change subject: [WIP]src/drivers/spi: Read Winbond's flash protection bits ......................................................................
Patch Set 5:
(9 comments)
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c@69 PS1, Line 69: printk(BIOS_WARNING, : "SF: Failed t
Now that the command can contain more than one byte do you want to do something like this: […]
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/spi_flash.c@438 PS1, Line 438: t
|| !region
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@199 PS1, Line 199:
part
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@204 PS1, Line 204:
size_t i
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@219 PS1, Line 219:
use a macro for this?
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@233 PS1, Line 233: prot
part
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@238 PS1, Line 238: f a p
size_t?
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@266 PS1, Line 266: &re
Do you really need to divide by KiB? […]
Done
https://review.coreboot.org/#/c/25082/1/src/drivers/spi/winbond.c@285 PS1, Line 285: s
magic value. […]
Done
-
Philipp Deppenwiese (Code Review)