Change in coreboot[master]: mb/lenovo/t530/devicetree: Trim DID entries to actual size.

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Peter Lemenkov (Code Review)

4 Feb 2020 4 Feb '20

10:56 a.m.

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/t530/devicetree: Trim DID entries to actual size. ......................................................................

mb/lenovo/t530/devicetree: Trim DID entries to actual size.

Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t530/variants/t530/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38707/1

diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb index 674b0f8..6f6dd1c 100644 --- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb @@ -1,7 +1,7 @@ chip northbridge/intel/sandybridge # IGD Displays register "gfx.ndid" = "3" - register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"

# Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06"

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Paul Menzel (Code Review)

4 Mar 4 Mar

1:29 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/t530/devicetree: Trim DID entries to actual size. ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38707/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38707/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/t530/devicetree: Trim DID entries to actual size. Please remove the dot/period at the end of the commit message summary.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 04 Mar 2020 16:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

1:31 p.m.

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/t530/devicetree: Trim DID entries to actual size. ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38707/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38707/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/t530/devicetree: Trim DID entries to actual size.

...

Please remove the dot/period at the end of the commit message summary.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 04 Mar 2020 16:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

1:31 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t530/devicetree: Trim DID entries to actual size

Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38707

to look at the new patch set (#3).

Change subject: mb/lenovo/t530/devicetree: Trim DID entries to actual size ......................................................................

mb/lenovo/t530/devicetree: Trim DID entries to actual size

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38707/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Peter Lemenkov (Code Review)

6 Mar 6 Mar

7:48 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38707

to look at the new patch set (#5).

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

mb/lenovo/*/devicetree: Trim DID entries to actual size

Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t400/devicetree.cb M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x200/devicetree.cb M src/mainboard/lenovo/x201/devicetree.cb M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb 15 files changed, 15 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38707/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

3:46 p.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG@7 PS5, Line 7: DID entries The real question is: do they make any sense, or can they be removed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 06 Mar 2020 18:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

10 Mar 10 Mar

8:32 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG@7 PS5, Line 7: DID entries

...

The real question is: do they make any sense, or can they be removed?

Looks like they can be replaced with some default values at least. I've found just a few boards which use different DID list.

On the other hand it's a part of board technical specification so maybe it's better to declare it in a devicetree explicitly anyway.

I believe it's better to discuss it separately (in a different commit).

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 10 Mar 2020 11:32:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

27 Mar 27 Mar

12:03 p.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38707

to look at the new patch set (#6).

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

mb/lenovo/*/devicetree: Trim DID entries to actual size

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/38707/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

2:21 p.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38707/5//COMMIT_MSG@7 PS5, Line 7: DID entries

...

Looks like they can be replaced with some default values at least. […]

Agreed, it's better handled in a different change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 17:21:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Peter Lemenkov lemenkov@gmail.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

29 Mar 29 Mar

3:14 p.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

Patch Set 6:

Superseded by CB:39731

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 29 Mar 2020 18:14:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

3:14 p.m.

New subject: Change in coreboot[master]: mb/lenovo/*/devicetree: Trim DID entries to actual size

Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38707 )

Change subject: mb/lenovo/*/devicetree: Trim DID entries to actual size ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/38707 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6da5b3270c14b4953cd25b4d8776479eb8a239c8 Gerrit-Change-Number: 38707 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1849

days inactive

1903

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Paul Menzel (Code Review)
Peter Lemenkov (Code Review)