Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87173?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/starbook/tgl: Tidy GPIO comments for SATA ......................................................................
mb/starlabs/starbook/tgl: Tidy GPIO comments for SATA
This is a non-functional change, and only makes the GPIOs easier to read.
Change-Id: Iee7121aef28618c0877c97cf454dc1a279758c21 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87173 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/tgl/gpio.c 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 6cf5fab..b6f1526 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -44,6 +44,9 @@ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* Reset */ PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */
+ /* SATA */ + PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* PEDET */ + /* Wireless */ PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), /* BRI Data */ PAD_CFG_NF(GPP_F1, NONE, DEEP, NF1), /* BRI Response */ @@ -104,8 +107,6 @@ PAD_NC(GPP_A7, NONE), /* A10: WLAN_PCM_IN */ PAD_NC(GPP_A10, NONE), - /* A12: SATAGP_1 */ - PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* A13: Not Connected */ PAD_NC(GPP_A13, NONE), /* A14: Not Connected */