Attention is currently required from: Jason Glenesk, Matt DeVillier, Jon Murphy, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74280 )
Change subject: soc/amd/phoenix: Update XHCI events
......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File src/soc/amd/phoenix/xhci.c:
https://review.coreboot.org/c/coreboot/+/74280/comment/5af85d64_9b3a31e9
PS13, Line 3: /* TODO: Update for Phoenix */
Not for this change.
@Felix, Can you please help update this table. There are supposed to be 4 XHCI controllers and only 2 of them under GPP Bridge A are configured in the table.
We also need to update the table to include XHCI controllers downstream of GPP Bridge C.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ca4f84fb0f1fef8441ab6ef7b6f6348c52b2922
Gerrit-Change-Number: 74280
Gerrit-PatchSet: 13
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 18 Apr 2023 18:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment