Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Subrata Banik, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81333?usp=email )
Change subject: mb/google/rex: Add Intel Touch for controller 1 for Rex
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81333/comment/e0b15990_5fc7a5e0 :
PS2, Line 33: THC NOTE for P1 and P2:reworked
Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/81333/comment/f9353863_a84c87ac :
PS2, Line 84: register "thc_configuration" = "THC_CONFIG_DOUBLE_CONTROLLER"
This reads not very nice. Can you come up with other value names?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81333?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id89b5b46d67b90491410d3d08c1a3ae9549b4da5
Gerrit-Change-Number: 81333
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jingyuan Liang
jingyliang@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 02 Apr 2024 09:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment