Attention is currently required from: Tim Wawrzynczak, Ivy Jian, Eric Lai, Lean Sheng Tan.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63628 )
Change subject: lib: Treat dimm addr_map 0 as not exist
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63628/comment/4851bded_1adb39ac
PS3, Line 7: not exist
nit: Maybe "invalid" is better word? Or "non-existent".
https://review.coreboot.org/c/coreboot/+/63628/comment/72967ddc_b1c325d9
PS3, Line 9: not exist
Same as above.
https://review.coreboot.org/c/coreboot/+/63628/comment/4e1a179e_3567c588
PS3, Line 10: there no HW exist
no HW exists
or
HW is unabailable / Hw is not present
File src/lib/spd_cache.c:
https://review.coreboot.org/c/coreboot/+/63628/comment/5c4c8d4e_0a916fb7
PS2, Line 159: is not exist
"does not exist"
File tests/lib/spd_cache-test.c:
https://review.coreboot.org/c/coreboot/+/63628/comment/bf8575e7_298c75c1
PS3, Line 143:
Can you add test case with .addr_map containing zero? New fragment of code should be covered by tests.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac
Gerrit-Change-Number: 63628
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 09:12:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment