build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )
Change subject: security/vboot: Add measured boot mode ......................................................................
Patch Set 48:
(7 comments)
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@98 PS48, Line 98: BUG(); /* Should never get called if init() returned an error. */ Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@10... PS48, Line 104: BUG(); /* Should never get called if init() returned an error. */ Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@28... PS48, Line 281: return vboot_extend_pcr(ctx, 0, BOOT_MODE_PCR) || vboot_extend_pcr(ctx, 1, HWID_DIGEST_PCR); line over 80 characters
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@30... PS48, Line 308: if (IS_ENABLED(CONFIG_RESUME_PATH_SAME_AS_BOOT) && vboot_platform_is_resuming()) line over 80 characters
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@31... PS48, Line 319: if (IS_ENABLED(CONFIG_VBOOT_MEASURED_BOOT) && !vboot_platform_is_resuming()) { line over 80 characters
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@32... PS48, Line 324: if (IS_ENABLED(CONFIG_VBOOT_PHYSICAL_DEV_SWITCH) && get_developer_mode_switch()) line over 80 characters
https://review.coreboot.org/#/c/29547/48/src/security/vboot/vboot_logic.c@33... PS48, Line 333: if (IS_ENABLED(CONFIG_VBOOT_WIPEOUT_SUPPORTED) && get_wipeout_mode_switch()) line over 80 characters
-
build bot (Jenkins) (Code Review)