Change in coreboot[master]: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
......................................................................

xeon_sp/cpx/: Remove duplicate defines in pci_devs.h

Change-Id: I8fc4e07269175eb2f40655b828e340697a9a892a
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
1 file changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45219/1

diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
index 17f801b..bcce308 100644
--- a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
+++ b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
@@ -75,19 +75,6 @@
 #define VTD_DEV			5
 #define VTD_FUNC		0

-#define VMD_DEV_NUM             0x05
-#define VMD_FUNC_NUM            0x05
-
-#define APIC_DEV_NUM            0x05
-#define APIC_FUNC_NUM           0x04
-
-#define CBDMA_DEV_NUM           0x04
-#define IIO_CBDMA_MMIO_SIZE     0x10000 //64kB for one CBDMA function
-
-#define PCH_IOAPIC_BUS_NUMBER   0x00
-#define PCH_IOAPIC_DEV_NUM      0x1F
-#define PCH_IOAPIC_FUNC_NUM     0x00
-
 /* PCH Device info */

#define  XHCI_BUS_NUMBER        0x0
@@ -114,7 +101,6 @@
 #define  PCH_DEV_PMC            _PCH_DEV(LPC, 2)
 #define  PCH_DEV_SPI            _PCH_DEV(LPC, 5)

-
 #define CBDMA_DEV_NUM           0x04
 #define IIO_CBDMA_MMIO_SIZE     0x10000 //64kB for one CBDMA function

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45219/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45219/2//COMMIT_MSG@7 
PS2, Line 7: xeon_sp/cpx/: Remove duplicate defines in pci_devs.h
veeery minor nit: I'd put the file name in the prefix:

xeon_sp/cpx/pci_devs.h: Remove duplicate defines

I don't mind either approach, though

Change in coreboot[master]: xeon_sp/cpx/pci_devs.h: Remove duplicate defines

[Marc Jones (Code Review)]

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Jay Talbott, Johnny Lin, Angel Pons, Bryant Ou, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45219

to look at the new patch set (#3).

Change subject: xeon_sp/cpx/pci_devs.h: Remove duplicate defines
......................................................................

xeon_sp/cpx/pci_devs.h: Remove duplicate defines

Change-Id: I8fc4e07269175eb2f40655b828e340697a9a892a
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
1 file changed, 0 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45219/3

Change in coreboot[master]: xeon_sp/cpx/pci_devs.h: Remove duplicate defines

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/pci_devs.h: Remove duplicate defines
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: xeon_sp/cpx/pci_devs.h: Remove duplicate defines

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/pci_devs.h: Remove duplicate defines
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: xeon_sp/cpx/pci_devs.h: Remove duplicate defines

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/pci_devs.h: Remove duplicate defines
......................................................................

xeon_sp/cpx/pci_devs.h: Remove duplicate defines

Change-Id: I8fc4e07269175eb2f40655b828e340697a9a892a
Signed-off-by: Marc Jones 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45219
Reviewed-by: Jay Talbott 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
1 file changed, 0 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Jay Talbott: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
index 17f801b..3781783 100644
--- a/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
+++ b/src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h
@@ -71,23 +71,6 @@
 #define VTD_CAP_HIGH			0x0C
 #define VTD_EXT_CAP_HIGH		0x14

-#define MMAP_VTD_CFG_REG_DEVID	0x2024
-#define VTD_DEV			5
-#define VTD_FUNC		0
-
-#define VMD_DEV_NUM             0x05
-#define VMD_FUNC_NUM            0x05
-
-#define APIC_DEV_NUM            0x05
-#define APIC_FUNC_NUM           0x04
-
-#define CBDMA_DEV_NUM           0x04
-#define IIO_CBDMA_MMIO_SIZE     0x10000 //64kB for one CBDMA function
-
-#define PCH_IOAPIC_BUS_NUMBER   0x00
-#define PCH_IOAPIC_DEV_NUM      0x1F
-#define PCH_IOAPIC_FUNC_NUM     0x00
-
 /* PCH Device info */

#define  XHCI_BUS_NUMBER        0x0
@@ -114,7 +97,6 @@
 #define  PCH_DEV_PMC            _PCH_DEV(LPC, 2)
 #define  PCH_DEV_SPI            _PCH_DEV(LPC, 5)

-
 #define CBDMA_DEV_NUM           0x04
 #define IIO_CBDMA_MMIO_SIZE     0x10000 //64kB for one CBDMA function

Change in coreboot[master]: xeon_sp/cpx/pci_devs.h: Remove duplicate defines

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45219 )

Change subject: xeon_sp/cpx/pci_devs.h: Remove duplicate defines
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19572
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19571
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19570
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19569
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19568
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19576
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19575
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19574
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19573

Please note: This test is under development and might not be accurate at all!