Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60645 )
Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Oh, I forgot one thing: You also leave it to reviewers […]
sorry I looked at these out-of-order and just noticed this one.
Nico, do you have a pointer to somewhere where not mixing syntaxes was discussed? Perhaps I forgot or missed that one.
IMHO, there are a few ways to approach this:
1) Wholesale, per-file changes, ensuring that the resulting AML does not change.
2) medium Per-Method or per-Device changes
3) Small, per-operand changes which are nearly trivial to review
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2a0b13522761e7113d1dc5b78d0dfd19a6cfd94
Gerrit-Change-Number: 60645
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 03 Jan 2022 01:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment