Attention is currently required from: Subrata Banik, Nick Vaccaro, Angel Pons, Arthur Heymans, Lean Sheng Tan, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63518 )
Change subject: soc/intel/common/{sa, adl}: Add `finalize` operation for systemagent
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/63518/comment/82e9922e_ce137fd5
PS2, Line 337: skip = CONFIG(USE_FSP_NOTIFY_PHASE_END_OF_FIRMWARE),
is it harmful to attempt to lock the PAM registers twice? i.e., does this need to be skipped only if the Kconfig is true or can we always send it? i.e., sa_final() would just be set to e.g.
```
static void systemagent_final(struct device *dev)
{
sa_lock_pam();
}
```
also are there more steps to come here later?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd464d2507393ed0c746eb1fbd10e36092ed5599
Gerrit-Change-Number: 63518
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 19:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment