Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60486 )
Change subject: soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ......................................................................
soc/intel/cannonlake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
Replace `Add (a, b, c)` with `c = a + b`.
Change-Id: Ibc5aeb5e8d85556d7564033ec92deb5b2dae093d Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/cannonlake/acpi/gpio.asl M src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi/gpio.asl b/src/soc/intel/cannonlake/acpi/gpio.asl index a1bc375..375a6a3 100644 --- a/src/soc/intel/cannonlake/acpi/gpio.asl +++ b/src/soc/intel/cannonlake/acpi/gpio.asl @@ -91,7 +91,7 @@ Local1 = Arg0 - GPP_C0 } Store (PCRB (Local0), Local2) - Add (Local2, PAD_CFG_BASE, Local2) + Local2 += PAD_CFG_BASE Return (Add (Local2, Multiply (Local1, 16))) }
diff --git a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl index 5007d96..db4b53d 100644 --- a/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl +++ b/src/soc/intel/cannonlake/acpi/gpio_cnp_h.asl @@ -91,6 +91,6 @@ Local1 = Arg0 - GPP_I0 } Store (PCRB (Local0), Local2) - Add (Local2, PAD_CFG_BASE, Local2) + Local2 += PAD_CFG_BASE Return (Add (Local2, Multiply (Local1, 16))) }