Change in ...coreboot[master]: mb/lenovo/r500: Add mainboard - coreboot-gerrit

8 Feb 2019


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28644 )
Change subject: mb/lenovo/r500: Add mainboard
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig 
File src/mainboard/lenovo/t400/Kconfig:
https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig@13 
PS7, Line 13: 	select BOARD_ROMSIZE_KB_8192
            : 	select BOARD_ROMSIZE_KB_4096 if BOARD_LENOVO_R500
...
Doesn't this conflict?
It iterates from small to big in mainboard/Kconfig so it works... Still better to make it more explicit.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28644
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e129b2e916acdf2b8534fa9d8d2cfc8f64f5815
Gerrit-Change-Number: 28644
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 08 Feb 2019 17:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment