Attention is currently required from: Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 46:
(36 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/fd5b5a65_ec50f7fe PS46, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/677b9ea4_e5b18011 PS46, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/35ceb472_208d3ced PS46, Line 218: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/bec22832_dc62149f PS46, Line 252: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/95e0606f_c9d3f0a8 PS46, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/f359c056_0d34eca9 PS46, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/790f9b5d_298f4652 PS46, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/af5aaa83_1f1c6f7b PS46, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/dfec99c4_fdae6ad2 PS46, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/958106d3_194c15e8 PS46, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/80d30946_ed250099 PS46, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/8ab7045d_0c72d731 PS46, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/7f143d9b_872c47d1 PS46, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/f50ba2f9_dee13920 PS46, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/090fb5bf_68db55e4 PS46, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/4b29fcd8_0c9f4e7c PS46, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/4df1ea69_9e23f3d5 PS46, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/bc16f6d0_4831bf4d PS46, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/63b60383_7581b42b PS46, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/0d35676d_1c2f036c PS46, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/36cd4ae5_89367c80 PS46, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/75808d87_c1fa4b32 PS46, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/dab6344d_da400087 PS46, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/bca863b3_3459a52a PS46, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/c63ccd1c_1940a1e9 PS46, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/86b53d62_59b57fd3 PS46, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/00fe530a_709d07f5 PS46, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/72d2cfc1_373c2dd9 PS46, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/14cb810e_df11390a PS46, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/a94006b6_40c19b24 PS46, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/2a088a18_8f9d0450 PS46, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/efe073e2_45958dcc PS46, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
File payloads/cbui/modules/rw_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/75521242_c8db81c6 PS46, Line 270: static struct rw_pci_index_data* rw_get_pci_dev_id(struct rw_presenter *this) "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/8b12401a_e5075867 PS46, Line 346: int count = sizeof(cell_buffers) / sizeof(cell_buffers[0]); Prefer ARRAY_SIZE(cell_buffers)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/62f0b999_1e31e907 PS46, Line 439: int count = sizeof(cell_buffers) / sizeof(cell_buffers[0]); Prefer ARRAY_SIZE(cell_buffers)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159690): https://review.coreboot.org/c/coreboot/+/23586/comment/65c948f2_3f2ab9fd PS46, Line 543: else if (cache->key == KEY_DOWN || cache->key == KEY_RIGHT) { else should follow close brace '}'
-
build bot (Jenkins) (Code Review)