Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib ......................................................................
Patch Set 2:
(5 comments)
File payloads/libpayload/include/arm64/arch/io.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119034): https://review.coreboot.org/c/coreboot/+/53903/comment/7c7cd2b9_6008f42b PS2, Line 154: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119034): https://review.coreboot.org/c/coreboot/+/53903/comment/a62f94db_9235f34d PS2, Line 159: } void function return statements are not generally useful
File src/commonlib/include/commonlib/coreboot_tables.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119034): https://review.coreboot.org/c/coreboot/+/53903/comment/29ab571f_1abd9c01 PS2, Line 332: uint32_t tag; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119034): https://review.coreboot.org/c/coreboot/+/53903/comment/c99e43c2_01f9255b PS2, Line 333: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119034): https://review.coreboot.org/c/coreboot/+/53903/comment/cc308fcd_9fe95378 PS2, Line 334: void *config_base; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)